----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37683/#review96056 -----------------------------------------------------------
Ship it! Ship It! - Darrel Schneider On Aug. 21, 2015, 9:36 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37683/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 9:36 a.m.) > > > Review request for geode and Darrel Schneider. > > > Bugs: GEODE-246 > https://issues.apache.org/jira/browse/GEODE-246 > > > Repository: geode > > > Description > ------- > > I added this test earlier in the week with pull request #15 and just noticed > that its use of JUnitParams needs to be simplified. I also found a couple > assertions to add to make the test more valuable. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/web/controllers/WanCommandsControllerJUnitTest.java > fb39d8c > > Diff: https://reviews.apache.org/r/37683/diff/ > > > Testing > ------- > > WanCommandsControllerJUnitTest > test > > > Thanks, > > Kirk Lund > >
