----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37970/#review97364 -----------------------------------------------------------
Ship it! Ship It! - Ashvin A On Aug. 31, 2015, 10:01 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37970/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2015, 10:01 p.m.) > > > Review request for geode, Ashvin A and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > The earlier attempt was not storing the binary data in the index. With > Lucene 5.3, we can add StringFields with binary data, so that's what > this code is now doing. > > Adding the unit tests for update and delete with both binary and > string keys. > > > Diffs > ----- > > gemfire-lucene/build.gradle b21339b083e92a272540bc74d88bac4b08564ed3 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/SerializerUtil.java > 07e89c96801cbc8445df6a0653dfea36ae8445fc > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/SingleIndexRepositoryImplJUnitTest.java > bfae55a2efa42e4436f815d98cee17f56d50d403 > > Diff: https://reviews.apache.org/r/37970/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
