> On Sept. 11, 2015, 6:43 p.m., Dan Smith wrote: > > Looks good! One very minor comment - we might want to put this is a > > directory with a different name than "build" The gradle output directories > > are called build, so for example our .gitignore file will exclude > > everything in there. Maybe dev-tools/docker? Otherwise, ship it!
thank you for letting me know, Dan. will change it - jun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35541/#review98660 ----------------------------------------------------------- On Sept. 11, 2015, 6:38 p.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35541/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2015, 6:38 p.m.) > > > Review request for geode. > > > Bugs: GEODE-60 > https://issues.apache.org/jira/browse/GEODE-60 > > > Repository: geode > > > Description > ------- > > Added Dockerfile for docker to build a container which lets users to build > Geode. > > > Diffs > ----- > > README.md 8ac89a0 > dev-tools/build/Dockerfile PRE-CREATION > dev-tools/build/start-docker.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/35541/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > jun aoki > >
