----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38581/#review100008 -----------------------------------------------------------
Ship it! Ship It! - Dan Smith On Sept. 21, 2015, 11:45 p.m., Ashvin A wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38581/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 11:45 p.m.) > > > Review request for geode and Dan Smith. > > > Repository: geode > > > Description > ------- > > GEODE-11: Make StringQueryProvider DataSerializable > > StringQueryProvider will be sent over wire and should be serialized > efficiently > using DataSerializableFixedId > > GEODE-11: Make LuceneFunctionContext DataSerializable > > LuceneFunctionContext will be sent over wire and needs to be serialized > efficiently using DataSerializableFixedID > > GEODE-11: Make Lucene Entry objects DataSerializable > > All Entry related objects (EntryScore, TopEntries, TopEntriesCollector and > CollectorManager) will be sent on wire and need to serialzed. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java > 98efb3ef0501d69277939ed6b8de2e6cd4c80f49 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java > cee9dc9422c615263ac33d711b29d1df9d0d1105 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProvider.java > e249aea2a594b8512e1c11aad7265052fe4ec0c9 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/EntryScore.java > 6903dce1e7aced1c6b01b4ec26c0ece86752f08d > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionContext.java > ad0fdfb95682b0f3dbb886d4c04766f3436c3d07 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntries.java > 3a07d3feb31b6fbb5d4eacc26bcf80796cf84409 > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesCollector.java > a4b5144e49c9e37621060d67c95ff5ef08fe873f > > gemfire-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesCollectorManager.java > bf7a265076d3edb3cc5a5da574139698daaa5fff > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/StringQueryProviderJUnitTest.java > 9d8b88c5b1789fef1d1a1271aa1c1b2f4eb52cca > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/EntryScoreJUnitTest.java > PRE-CREATION > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionContextJUnitTest.java > PRE-CREATION > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionJUnitTest.java > c354411f38d855c8c9cf048deab5e7da1a948562 > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesCollectorJUnitTest.java > 3cf622c3954e43ca23e8b95dd6e6135d841f4b2b > > gemfire-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/distributed/TopEntriesJUnitTest.java > b799a00e8c31785744bb907b1be93ecc2fbc2f74 > > Diff: https://reviews.apache.org/r/38581/diff/ > > > Testing > ------- > > > Thanks, > > Ashvin A > >
