> On Oct. 13, 2015, 10:43 p.m., Darrel Schneider wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java, > > line 2667 > > <https://reviews.apache.org/r/39295/diff/1/?file=1097850#file1097850line2667> > > > > This code gets duplicated. > > It looks like you could refactor it into a single method that handles > > an event given the event and a Set<MembershipListener>
Thanks. I'll look into that. - Barry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39295/#review102551 ----------------------------------------------------------- On Oct. 13, 2015, 10:26 p.m., Barry Oglesby wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39295/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 10:26 p.m.) > > > Review request for geode, Anthony Baker, Bruce Schuchardt, and Jacob Barrett. > > > Bugs: GEODE-402 > https://issues.apache.org/jira/browse/GEODE-402 > > > Repository: geode > > > Description > ------- > > Added exception handling for all callbacks > Refactored handler code > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/DistributionManager.java > 36d160248647b5a25bf1e82e8d7709dfb84d0261 > > Diff: https://reviews.apache.org/r/39295/diff/ > > > Testing > ------- > > > Thanks, > > Barry Oglesby > >
