----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39605/#review103824 -----------------------------------------------------------
Ship it! gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetView.java (line 155) <https://reviews.apache.org/r/39605/#comment161924> yes, please add it - Bruce Schuchardt On Oct. 23, 2015, 6:10 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39605/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 6:10 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Jianxia Chen, > and Lynn Gallinat. > > > Repository: geode > > > Description > ------- > > It looks like the coordinator node has left, sent a leave message but the > member that is supposed to become coordinator next, ignores this leave > message (as he is not yet the coordinator). > The fix is to not ignore these leave messages and instead have each member > track them, similar to removedMembers list. When the leave message is > processed by non coordinators, the results will be the same. However if the > non coordinator will now become coordinator, they can now process these leave > messages > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/NetView.java > cb61a1b > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > ed9f214 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeave.java > 57611e6 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/membership/GMSJoinLeaveJUnitTest.java > 42594cf > > Diff: https://reviews.apache.org/r/39605/diff/ > > > Testing > ------- > > Ran precheckin but had a handful of failures due to suspect strings, will > rerun > > > Thanks, > > Jason Huynh > >
