----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39765/#review104472 -----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestPart1DUnitTest.java (line 170) <https://reviews.apache.org/r/39765/#comment162728> Why add "Connection reset" since it is a SocketException and this test already expects that? Looking at the original suspect string for 454 I think your addition of "Unexpected IOException" is good enough. - Darrel Schneider On Oct. 29, 2015, 11:32 a.m., Ashvin A wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39765/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 11:32 a.m.) > > > Review request for geode, Darrel Schneider and Dan Smith. > > > Repository: geode > > > Description > ------- > > This test restarts 3 members while the client is connected. Like other fixes > (see > GEODE-453), I think IOExceptions should be expected in this case also. I > count > not reproduce this bug locally. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAInterestPart1DUnitTest.java > ba6e30f666c4d67d9c6a359da924d39c9d59a139 > > Diff: https://reviews.apache.org/r/39765/diff/ > > > Testing > ------- > > > Thanks, > > Ashvin A > >
