----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40362/#review106715 -----------------------------------------------------------
Ship it! Ship It! - Anthony Baker On Nov. 16, 2015, 7:45 p.m., Mark Bretl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40362/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 7:45 p.m.) > > > Review request for geode, Anthony Baker, Dick Cavender, and Dan Smith. > > > Bugs: GEODE-151 > https://issues.apache.org/jira/browse/GEODE-151 > > > Repository: geode > > > Description > ------- > > The build was using the executable git command to populate version > information, which created big blocks of Gradle code and could be > unstable. All Git executable commands have been changed to use the > Gradle Git plugin. If directory is not a valid Git workspace, then > it will log a warning and use default values to populate version > information. > > > Diffs > ----- > > build.gradle e3b1033e1205ed3064691ecfd63fe92f08096af4 > gemfire-core/build.gradle 80761ed8894567f20b450caa059ea4526b24b0ee > > Diff: https://reviews.apache.org/r/40362/diff/ > > > Testing > ------- > > Tested compiling with and without Git workspace. Verified > GemFireVersion.properties is correct. > > > Thanks, > > Mark Bretl > >