> On Nov. 17, 2015, 8:35 p.m., Dan Smith wrote: > > The javadoc command actually worked for me without this flag (using openjdk > > 1.8.0_45 on linux). But if other JDK's are having issues, seems like a good > > fix. > > Nitin Lamba wrote: > Good point. Probably, this only shows-up with Oracle JDK. > > Did the change have any side-effects on OpenJDK or was the new option > ignored?
No side effects that I can tell. I guess the option is just ignored or it's already disabled with openjdk. Anyway, openjdk works fine with your changes. Ship it! - Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40395/#review106931 ----------------------------------------------------------- On Nov. 17, 2015, 8:02 p.m., Nitin Lamba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40395/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 8:02 p.m.) > > > Review request for geode, Dick Cavender, Mark Bretl, and Dan Smith. > > > Repository: geode > > > Description > ------- > > Currently, the javadoc command errors out with JDK 8. The fix is to ignore > strict checking. > > > Diffs > ----- > > build.gradle a186710 > > Diff: https://reviews.apache.org/r/40395/diff/ > > > Testing > ------- > > Tested on local dev setup. > > > Thanks, > > Nitin Lamba > >