----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40516/#review107289 -----------------------------------------------------------
Ship it! Looks good ! Just one minor comment. gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/BucketCountLoadProbe.java (line 54) <https://reviews.apache.org/r/40516/#comment166321> Just curious, is it better to set the bucketSize as -1 or null, instead of a valid value? There is no issue with using 1 in the current code. It will work as there is only one load probe per cache. So all buckets (across regions) will be compared uniformly. - Ashvin A On Nov. 20, 2015, 12:57 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40516/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 12:57 a.m.) > > > Review request for geode, Ashvin A and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Adding a load probe that balances partitioned regions based on bucket > count, rather than on the amount of data in bytes on each node. > > > Diffs > ----- > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/DSFIDFactory.java > c6fc451704d8ae5ed79b71b3f383b829801e7cae > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/DataSerializableFixedID.java > fa2b00c210e8af572ca23cf97fe2bbc092752498 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/control/InternalResourceManager.java > 98e1f25b3ec647dc919ee3fc2f6e755a0717faa0 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/BucketCountLoadProbe.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/control/RebalanceOperationDUnitTest.java > 9029b8dac7fd9930a3a51fe1e5b7d53e758a3098 > > Diff: https://reviews.apache.org/r/40516/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
