> On Nov. 25, 2015, 6:59 p.m., Darrel Schneider wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheCreation.java, > > line 566 > > <https://reviews.apache.org/r/40715/diff/1/?file=1147088#file1147088line566> > > > > change "startBridgeServers" to "startCacheServers" > > > > Anytime you see "bridge" in client/server code change it. > > > > Why do we pass "this.getCacheServers()" to an instance method? Does it > > make unit testing easier?
Yes. To be able to unit test by passing a list of cache servers. - Sai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40715/#review108040 ----------------------------------------------------------- On Nov. 25, 2015, 7:34 p.m., Sai Boorlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40715/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 7:34 p.m.) > > > Review request for geode and anilkumar gingade. > > > Repository: geode > > > Description > ------- > > Before starting a cache-server or creating a region, verify that one has > not been created by cluster config. skip if already created. > > fixing compilation errors introduced by the merge. > > > reverting "skipping region creation" change > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheCreation.java > 14076b530b43a5b7087df33cecfea45e23ae03be > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheCreationJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/40715/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Sai Boorlagadda > >
