Thanks Jens and Vincent, I must read carefully about the license stuff, I thought it was just another project and so I included the files directly. Regarding geode dependency, I knew it was for testing purposes but currently there are not tests using those classes so I decided to remove the dependencies until they are really needed. I'll review these things on Monday, thanks again. Cheers.
On Friday, 4 December 2015, ASF GitHub Bot (JIRA) <j...@apache.org <javascript:_e(%7B%7D,'cvml','j...@apache.org');>> wrote: > > [ > https://issues.apache.org/jira/browse/GEODE-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041896#comment-15041896 > ] > > ASF GitHub Bot commented on GEODE-341: > -------------------------------------- > > Github user vfordpivotal commented on the pull request: > > > https://github.com/apache/incubator-geode/pull/46#issuecomment-162039056 > > A number of the pom.xml dependencies removed will need to be re-added > as they will be needed for testing (creating stats files...) which at > present is missing from this project. So jvsd itself doesn't require geode > code itself, the testing code will need it to generate test data and to > validate compatibility with geode generated stats files. > > > > Refactor Java packages to reflect Apache organization > > ----------------------------------------------------- > > > > Key: GEODE-341 > > URL: https://issues.apache.org/jira/browse/GEODE-341 > > Project: Geode > > Issue Type: Sub-task > > Components: general > > Reporter: Vincent Ford > > > > Change packages to reflect Apache code standards. > > Proposed packaging will be something like org.apache.geode.jvsd.* > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > -- Juan José Ramos Cassella Senior Technical Support Engineer *Email:* jra...@pivotal.io *Office#*: +353 21 4238611 *Mobile#*: +353 87 2074066 *After Hours Contact#*: 877 477 2269 *Working Hours*: Monday to Friday 08:30 - 17:00 GMT *How to upload artifacts:* https://support.pivotal.io/hc/en-us/articles/204369073 *How to escalate a ticket:* https://support.pivotal.io/hc/en-us/articles/203809556 <https://support.pivotal.io/hc/en-us/articles/203809556-Pivotal-How-do-I-escalate-an-existing-case->
