----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41141/#review109579 -----------------------------------------------------------
Ship it! Ship It! - Jianxia Chen On Dec. 9, 2015, 6:14 p.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41141/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2015, 6:14 p.m.) > > > Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh > Khamesra, and Jianxia Chen. > > > Repository: geode > > > Description > ------- > > Added tests for tcp check to check for an ok or error status > Commenting out setting the gemfire bind address property as it didn't appear > to affect any of these tests. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > cc64f9b > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java > 585ff17 > > Diff: https://reviews.apache.org/r/41141/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
