There's another review request for close part code changes. https://reviewboard.gemstone.com/r/3761/
GEODE-669 is just created. On Mon, Dec 14, 2015 at 10:33 AM, Dan Smith <dsm...@pivotal.io> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41332/#review110274 > ----------------------------------------------------------- > > > Can you file a JIRA for this? > > Also, would it make sense to add this sort of logic to Cache.getRegion? It > seems like there might be other code that is expecting to find a region > that previously existed, and the only reason that it is gone is because of > a shut down all. > > - Dan Smith > > > On Dec. 14, 2015, 1:06 a.m., xiaojian zhou wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/41332/ > > ----------------------------------------------------------- > > > > (Updated Dec. 14, 2015, 1:06 a.m.) > > > > > > Review request for geode and Dan Smith. > > > > > > Repository: geode > > > > > > Description > > ------- > > > > We need a cacheobserver for ShutdownAll. > > > > GatewayReceiverCommand will find the region of events will be null when > shutdownall is on-going. In this case, it will throw > CacheDestroyedException (i.e. subclass of CancelException) instead of > RegionDestroyedException. > > > > > > Diffs > > ----- > > > > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserver.java > 9cd6c28 > > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/CacheObserverAdapter.java > 82c4507 > > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java > 27bb813 > > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/command/GatewayReceiverCommand.java > 6d252e4 > > > > Diff: https://reviews.apache.org/r/41332/diff/ > > > > > > Testing > > ------- > > > > > > Thanks, > > > > xiaojian zhou > > > > > >
