----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41492/#review110915 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/stats/StatsKey.java <https://reviews.apache.org/r/41492/#comment170910> You removed this stats "eventQueueSize", vsd cannot show it any more. How about fix the size in stats too? - xiaojian zhou On Dec. 17, 2015, 2:43 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41492/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 2:43 a.m.) > > > Review request for geode, Ashvin A and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > The eventQueueSize stat has issues with concurrent events during start > and stop that are leading it to be inaccurate. To make gfsh and jmx > correct, measuring the queue size directly from the underlying region > size. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySender.java > 422c150fbf1e34785f79bbad54b52cd61594e64c > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/AbstractGatewaySenderEventProcessor.java > b9d877e1a0fab318ae8c29e8ea076bf4d42fb051 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java > 94dc9e8708df08221d26791dd53ab0070657afae > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/serial/ConcurrentSerialGatewaySenderEventProcessor.java > 16410cec806618eff49a3a4611e257cbfa8278a6 > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/GatewaySenderMBeanBridge.java > 0b6f4325998b56ba03ede0dc01350f941c7e606b > > gemfire-core/src/main/java/com/gemstone/gemfire/management/internal/beans/stats/StatsKey.java > 50972923b5ff4842822ba30d039bb5c56f66509f > > Diff: https://reviews.apache.org/r/41492/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
