----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41557/#review111284 -----------------------------------------------------------
Ship it! Ship It! - Sai Boorlagadda On Dec. 18, 2015, 5:56 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41557/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 5:56 p.m.) > > > Review request for geode and Sai Boorlagadda. > > > Repository: geode > > > Description > ------- > > Commented out dead code. > Added tests for getMemoryAddress and toString. > Added MemoryChunkTestSuite. > Added some readAbsoluteBytes tests. > Improved assertion coverage. > Also improved OffHeapStorage coverage. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java > 3eb839b5d5624439e7c44b0bfcc5f38fc893edec > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunk.java > 4f0e86d6725d6bab2b5b850bb71edd34d34bcee0 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryChunkJUnitTestBase.java > c8c0b2b4c178e610781776b79b4cc3e5c1f51ca7 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/MemoryChunkTestSuite.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java > de21487badaa9262d5cc4e329cbb6375fb627e7c > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/UnsafeMemoryChunkJUnitTest.java > cf6ba4485ccfee3ee389aa17d0d911ad6eaa3831 > > Diff: https://reviews.apache.org/r/41557/diff/ > > > Testing > ------- > > off-heap unit tests > > > Thanks, > > Darrel Schneider > >
