----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41581/#review111506 -----------------------------------------------------------
Ship it! The change looks good, but it would be nice to use a standard method for waiting for an event to occur. Either a WaitCriterion or this awaitility library that Kirk has started using more recently. - Dan Smith On Dec. 19, 2015, 2:14 a.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41581/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2015, 2:14 a.m.) > > > Review request for geode and Dan Smith. > > > Repository: geode > > > Description > ------- > > It's not reproducing of GEODE-329. > > What happened is: The DistributedTestCase.disconnectFromDS() will close the > cache in another thread. > > The next step to createPR(vm0, 0) should wait for the first cache is really > closed. Otherwise, there's chance that the closing cache is still on going. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java > 39ffb11 > > Diff: https://reviews.apache.org/r/41581/diff/ > > > Testing > ------- > > The dunit test > > > Thanks, > > xiaojian zhou > >
