----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41615/#review111670 -----------------------------------------------------------
Ship it! Ship It! - Jens Deppe On Dec. 22, 2015, 12:13 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41615/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 12:13 a.m.) > > > Review request for geode, Jens Deppe and Jinmei Liao. > > > Bugs: GEODE-473 > https://issues.apache.org/jira/browse/GEODE-473 > > > Repository: geode > > > Description > ------- > > GEODE-473: Capture status file lines in finally block > > Change FileProcessController status handler to capture lines read from > status file in finally block. > > * Add new UnitTest for LocatorState > > * Add new IntegrationTest for FileProcessController > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/process/FileProcessController.java > 471877f > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/LocatorStateJUnitTest.java > PRE-CREATION > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/process/FileProcessControllerIntegrationJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/41615/diff/ > > > Testing > ------- > > new LocatorStateJUnitTest > new FileProcessControllerIntegrationTest > LauncherTestSuite > precheckin > > > Thanks, > > Kirk Lund > >
