----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42008/#review113341 -----------------------------------------------------------
Ship it! Ship It! - Swapnil Bawaskar On Jan. 7, 2016, 1:03 a.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42008/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 1:03 a.m.) > > > Review request for geode, Scott Jewell and Swapnil Bawaskar. > > > Bugs: GEODE-701 > https://issues.apache.org/jira/browse/GEODE-701 > > > Repository: geode > > > Description > ------- > > The failure was caused by LifecycleListenerJUnitTest setting > a system property and then not unsetting it when it completed. > testClose now asserts that the system property must be initially > false when it runs. > LifecycleListenerJUnitTest now unsets the property in a finally > block after setting it. > > > Diffs > ----- > > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/LifecycleListenerJUnitTest.java > c886e4372559055f1724f9f66cd97d7af73fd41b > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SimpleMemoryAllocatorJUnitTest.java > 6bc488dc797d0560d7f6a0b7278609abfd78fa7a > > Diff: https://reviews.apache.org/r/42008/diff/ > > > Testing > ------- > > Ran LifecycleListenerJUnitTest and SimpleMemoryAllocatorJUnitTest. > > > Thanks, > > Darrel Schneider > >
