----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42465/#review115118 -----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolder2JUnitTest.java (line 148) <https://reviews.apache.org/r/42465/#comment175976> Special exception should be: next=this.version+1, but previous will never be this.version. It could be this.version-1 or smaller. So your code should be: h.addException(h.getVersion()-1, h.getVersion()+1); Other code changes look good. Make sure that with my suggested change, the test will still pass. - xiaojian zhou On Jan. 18, 2016, 6:29 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42465/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 6:29 p.m.) > > > Review request for geode, Dan Smith and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > This is from a group refactoring session during a class taught by Michael > Feathers. The old recordVersion code was difficult to understand and was > poorly tested. New JUnit tests are now included that give 100% code coverage > for this algorithm. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolder.java > 4872df2a06c0bf6c949204cf98074d9259d6413f > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/versions/RegionVersionHolder2JUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42465/diff/ > > > Testing > ------- > > precheckin including new tests > > > Thanks, > > Bruce Schuchardt > >
