> On Jan. 19, 2016, 11:03 a.m., Swapnil Bawaskar wrote: > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SyncChunkStackJUnitTest.java, > > line 19 > > <https://reviews.apache.org/r/42479/diff/1/?file=1200836#file1200836line19> > > > > I think we need to run all our tests with assertions. Rahter than > > adding here, can you please add `-ea` to all the test targets in gradle > > scripts?
For code coverage in all test environments (for example running the unit test in an IDE) I want to enable assertions in the test code. I think assertions are already enabled when run from gradle. - Darrel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42479/#review115213 ----------------------------------------------------------- On Jan. 18, 2016, 4:46 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42479/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2016, 4:46 p.m.) > > > Review request for geode and Swapnil Bawaskar. > > > Bugs: GEODE-783 > https://issues.apache.org/jira/browse/GEODE-783 > > > Repository: geode > > > Description > ------- > > added unit test for SyncChunkStack > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/SyncChunkStack.java > a615af0a601a1e0bdbbc5236e6c802944ca57caa > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/SyncChunkStackJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42479/diff/ > > > Testing > ------- > > ran SyncChunkStackJUnitTest > > > Thanks, > > Darrel Schneider > >
