----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42564/ -----------------------------------------------------------
Review request for geode, anilkumar gingade, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen. Repository: geode Description ------- MemoryIndexStore does not have unit tests at this time Minor refactor to allow this to take place. This will also make it possible for future refactors of the MemoryIndexStore as some of the methods in there might be broken out a bit. Planning on removing the static call to GemFireCacheImpl from the query/indexing code at some point. This will be the first step in doing so, eventually the reference to the cache could be removed for a call into an instance of indexmanager (or other interface) to retreive the time. Diffs ----- gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/MemoryIndexStore.java 41de5ea gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 9d77556 gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/MemoryIndexStoreJUnitTest.java PRE-CREATION gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/MemoryIndexStoreWithInplaceModificationJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/42564/diff/ Testing ------- Thanks, Jason Huynh
