----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42531/#review115459 -----------------------------------------------------------
Ship it! Ship It! - Scott Jewell On Jan. 20, 2016, 6:38 p.m., Darrel Schneider wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42531/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 6:38 p.m.) > > > Review request for geode, Scott Jewell, Ken Howe, Sai Boorlagadda, and > Swapnil Bawaskar. > > > Bugs: GEODE-798 > https://issues.apache.org/jira/browse/GEODE-798 > > > Repository: geode > > > Description > ------- > > testCreateOffHeapStorage now uses mocks. > Also a LocalStatisticsFactory can now be created without starting a sampler. > This allows it to be used a light weight StatisticsFactory compared to > InternalDistributedSystem. > The nice thing compared to a mocked StatisticsFactory is it will still create > functional Statistics instances. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/LocalStatisticsFactory.java > 6bd83c02d72854ad70ac81eff17ff22d94e54ad3 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapStorage.java > be27b5e8c5269011ea39a39059666a28ce9f2b6a > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapStorageJUnitTest.java > 24fb82bc333469347055e1259e743aa6ec1723fc > > Diff: https://reviews.apache.org/r/42531/diff/ > > > Testing > ------- > > OffHeapStorageJUnitTest and LocalStaticsFactory unit tests. > > > Thanks, > > Darrel Schneider > >
