I meant I ran './gradlew uiTest' in my setup for UI testing and got those errors. I do see those two lines on the PulseUI test so source code is up to date.
Were you able to run the UI tests completely without errors? In other classes, I had to add @Ignore for every test and have not used it for the class. Maybe it has the same effect. - Nitin ________________________________________ From: Jinmei Liao <jil...@pivotal.io> Sent: Friday, January 22, 2016 11:07 AM To: dev@geode.incubator.apache.org Subject: Re: Pulse UI merged to develop When you simply run "test", it shouldn't even run those uiTest at all since it's excluded from the test tasks. Do open up your PulseUITest.java and see if it has those lines on top of the class: @Ignore @Category(UITest.class) If not, then your source is not up to date? On Fri, Jan 22, 2016 at 10:13 AM, Nitin Lamba <ni...@ampool.io> wrote: > Response inline... > > ________________________________________ > From: Jinmei Liao <jil...@pivotal.io> > Sent: Friday, January 22, 2016 9:34 AM > To: dev@geode.incubator.apache.org > Subject: Re: Pulse UI merged to develop > > Nitin, thanks for the review. Good point on updating the Selenium version. > As to pulling the version numbers into the dependency property file, let's > wait on that since there is an effort going on to not include all the > transitive dependancies in our build script. Once that's done, it would be > a lot less effort trying to move these version numbers. > > [NL] Thanks. Makes sense to wait. > > Only PulseAutomatedTests are run as uiTest, (those others are just base > class for PulseAutomatedTests), We did @ignore the other tests such as > PulseUITest and the BaseServiceTest. > > [NL] For some reason, I don't see those ignored. Doing a clean build and > test on 'develop' still gives me three failures on PulseUITest: > com.vmware.gemfire.tools.pulse.testbed.driver.PulseUITest > > testMemberViewRegions FAILED > com.vmware.gemfire.tools.pulse.testbed.driver.PulseUITest > > testClusterViewTopRibbon FAILED > com.vmware.gemfire.tools.pulse.testbed.driver.PulseUITest > > testDataViewRegionProperties FAILED > > [NL] Also, I'm positive that the same UI tests are being run multiple > times - if you look at the ignored tests in the test report, you'll see > duplicate test entries. Using just one class runs all the tests and gives a > lot shorter test runtime. > > As to the environment variables to set up the tests, those are removed > intentionally. The tests don't depend on them anymore. It uses > classloader's getResource to find them. > > [NL] Great! Not sure what happened but when I ran the test suite first > time, the test web server (Tomcat) did not start-up for me. I'll update the > review request accordingly. Thanks > > Thanks! > > Jinmei > > On Fri, Jan 22, 2016 at 9:07 AM, Nitin Lamba <ni...@ampool.io> wrote: > > > Thanks Jinmei. > > > > I tried running Pulse UI tests but ran into few issues, listed below: > > > > 1. Firefox version has been updated so Selenium jars also requires a new > > version > > 2. During the process of cleaning-up build.gradle, setting-up test > > environmental variables was removed > > > > I submitted a review request/ patch for these [1]. Few other clean-up > > tasks below: > > > > 3. Only 'PulseAutomatedTests' needs to be run for UI. Based on test > > inheritance, those tests run correctly and only once. The rest of the > > tests, especially for back-end service are too old, should be ignored. > [2] > > has some good background on this topic from last year > > > > 4. In addition to updating the NOTICE/ LICENSE files, the build.gradle > > file should have hard-coded versions removed and inherited from a > separate > > properties file, just like the main project .gradle file > > > > - Nitin > > [1] https://reviews.apache.org/r/42659/ > > [2] https://issues.apache.org/jira/browse/GEODE-304 > > > > ________________________________________ > > From: Jinmei Liao <jil...@pivotal.io> > > Sent: Thursday, January 21, 2016 9:53 PM > > To: dev@geode.incubator.apache.org > > Subject: Re: Pulse UI merged to develop > > > > To run all the UI tests, you just do "./gradlew uiTest" in the command > > line. Currently these tests are not run in Jenkins since it would require > > Firefox to be launched. All the PulseAutomatedTest, PulseBaseTest and > > PulseTest are run as uiTest. > > > > licenses are updated on each file. Will update the LICENSE and NOTICE as > > well. > > > > As to the branding, I believe we will still leave Jira around to capture > > the work to be done. > > > > On Thu, Jan 21, 2016 at 5:43 PM, Nitin Lamba <ni...@ampool.io> wrote: > > > > > Great progress - thanks Jinmei and Jens! > > > > > > Tried to build 'develop' on my machine and started Pulse - launched as > > > expected. How does one launch UITests? I see those tests removed form > > > build.gradle file that were worked on last year. > > > > > > As mentioned, Pivotal/ Gemfire branding on the UI is still not fixed - > > see > > > attached. Per the JIRA[1], licensing was worked on a bit last November > > but > > > haven't seen any recent updates. The top-level JIRA (GEODE-12) captures > > all > > > the pending items - still a few unresolved. > > > > > > Ideally, shouldn't all the issues be addressed before merging into > > develop? > > > > > > - Nitin > > > [1] https://issues.apache.org/jira/browse/GEODE-511 > > > > > > ________________________________________ > > > From: Jinmei Liao <jil...@pivotal.io> > > > Sent: Thursday, January 21, 2016 3:32 PM > > > To: dev@geode.incubator.apache.org > > > Subject: Re: Pulse UI merged to develop > > > > > > Oh, no, not yet. But all the sources brought over has the corresponding > > > license headers, and gradle rat is running successfully. Will update > > those > > > LICENSE/NOTICE soon. > > > > > > On Thu, Jan 21, 2016 at 3:29 PM, Anthony Baker <aba...@pivotal.io> > > wrote: > > > > > > > Excellent! Have the LICENSE / NOTICE files been updated based on the > > new > > > > source and binary dependencies? > > > > > > > > Anthony > > > > > > > > > On Jan 21, 2016, at 3:15 PM, Gregory Chase <gch...@pivotal.io> > > wrote: > > > > > > > > > > + dev > > > > > > > > > > On Thu, Jan 21, 2016 at 3:12 PM, Jens Deppe <jensde...@apache.org> > > > > wrote: > > > > > > > > > >> Thanks to the work of Jinmei and Nitin, we now have the Geode > Pulse > > UI > > > > >> merged to develop! > > > > >> > > > > >> This does not bring any new features with it, but does make the UI > > > > >> automatically available when starting a locator. More information > > > about > > > > >> accessing Pulse can be found here: > > > > >> > > > > > > > > > > http://gemfire.docs.pivotal.io/docs-gemfire/latest/tools_modules/pulse/chapter_overview.html > > > > >> > > > > >> This does mean that Jiras can (and should) be filed against found > > bugs > > > > and > > > > >> for new features you would like to see in Pulse. > > > > >> > > > > >> After today's nightly build, you can download a distribution here > to > > > try > > > > >> it out: https://builds.apache.org/job/Geode-nightly/ > > > > >> > > > > >> --Jens > > > > >> > > > > > > > > > > > > > > > > > > > > -- > > > > > Greg Chase > > > > > > > > > > Director of Big Data Communities > > > > > http://www.pivotal.io/big-data > > > > > > > > > > Pivotal Software > > > > > http://www.pivotal.io/ > > > > > > > > > > 650-215-0477 > > > > > @GregChase > > > > > Blog: http://geekmarketing.biz/ > > > > > > > > > > > > > > > > > -- > > > Cheers > > > > > > Jinmei > > > > > > > > > > > -- > > Cheers > > > > Jinmei > > > > > > -- > Cheers > > Jinmei > -- Cheers Jinmei
