----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42769/#review116374 -----------------------------------------------------------
Ship it! I traced this code back to the early days of GemFire and it looks like the original intent was to give the locator thread time to spin up before continuing. The new GMS will wait long enough for the TCPServer to start up, but this change shouldn't be back-ported to GemFire maintenance branches where it could cause a GemFireConfigException when starting a DistributedSystem with a colocated locator. - Bruce Schuchardt On Jan. 26, 2016, 12:52 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42769/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 12:52 a.m.) > > > Review request for geode and Bruce Schuchardt. > > > Repository: geode > > > Description > ------- > > There is no reason for this sleep, it is causing tests to take longer. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java > 50a0fa95aa069ac51af079fad43996bccf9d598f > > Diff: https://reviews.apache.org/r/42769/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
