----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42817/#review116452 -----------------------------------------------------------
Ship it! Ship It! - Hitesh Khamesra On Jan. 26, 2016, 7:16 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42817/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 7:16 p.m.) > > > Review request for geode, Hitesh Khamesra and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Added a unit-test to reproduce the problem and then fixed waitToStop(). > > Gfsh's launcher is also modified to show an exception if one is thrown by the > locator. It was silently ignoring these, making diagnosis of problems pretty > difficult. > > InternalDistributedSystem is also modified to not close log appenders during > disconnect if an auto-reconnect is in progress. The auto-reconnect process > needs to have a log file to write status to, so we leave the log open. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/LocatorLauncher.java > 6846905ee60f58e54ac1a77462694a5bee6c769f > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalDistributedSystem.java > 087407a5ede51faf3fd2698e666871f0d336175f > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/InternalLocator.java > 50a0fa95aa069ac51af079fad43996bccf9d598f > > gemfire-core/src/test/java/com/gemstone/gemfire/cache30/ReconnectDUnitTest.java > b4a73bcb2108ff22b76e47fb5553375321171294 > > Diff: https://reviews.apache.org/r/42817/diff/ > > > Testing > ------- > > > Thanks, > > Bruce Schuchardt > >
