+1 The other cool thing about this change is the IDE will now know about the method calls. In your example it will now know that WANTestBase.createReceiver is being called. The fewer uses of reflection we have the better.
On Tue, Jan 26, 2016 at 2:10 PM, Swapnil Bawaskar <[email protected]> wrote: > +1 > > Since this is going to be a lot of tests, any ideas on how to split up the > work? > > On Tue, Jan 26, 2016 at 2:06 PM, Jinmei Liao <[email protected]> wrote: > > > +1 > > > > Jinmei > > > > > On Jan 26, 2016, at 2:02 PM, Dan Smith <[email protected]> wrote: > > > > > > I checked in a minor fix to allow you to use a lambda expression in > > > VM.invoke calls with our dunit framework. For example: > > > > > > String result = vm1.invoke(() -> "Hello from vm1!"); > > > > > > I think we should replace all of the VM.invoke calls that use strings > > with > > > lambdas instead. That will give us better compile time checks and make > it > > > easier navigate in the IDE. > > > > > > This: > > > vm2.invoke(WANTestBase.class, "createReceiver", new Object[] { nyPort > }); > > > > > > Should become: > > > vm2.invoke(() -> WANTestBase.createReceiver( nyPort )); > > > > > > What do you guys think? > > > -Dan > > >
