----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42822/#review116478 -----------------------------------------------------------
gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java (line 2165) <https://reviews.apache.org/r/42822/#comment177495> There is a pauseSender() and pauseSenderAndWaitForDispatcherToPause(). You just made the 2 methods identical. Was that purposely using pauseSender() here? Others look good. - xiaojian zhou On Jan. 26, 2016, 8:47 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42822/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 8:47 p.m.) > > > Review request for geode, Barry Oglesby and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > For parallel queues, there is a actually a separate conflation thread > that removes entries from the queue on conflation. The tests need to > wait for this thread to finish it's work. > > As part of this change, I refactored the ParallelWANConflationDUnitTest > to remove a bunch of duplicate code, replaced the VM.invoke(String) > calls with lambdas, and scaled the test down to create fewer buckets and > do fewer puts so that it runs in 1/4 of the time. > > > Diffs > ----- > > > gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java > 230c8d8ce6f903cf5e4b9c8bf42b87ca04271647 > > gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelWANConflationDUnitTest.java > 4acaaf4c5f24123db335e39ea56592717c9ea17c > > Diff: https://reviews.apache.org/r/42822/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
