----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42885/#review116669 -----------------------------------------------------------
Ship it! Ship It! - xiaojian zhou On Jan. 28, 2016, 12:43 a.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42885/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 12:43 a.m.) > > > Review request for geode, Barry Oglesby and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > This test was almost an exact copy of > SerialGatewaySenderOperationsDUnitTest, with a few lines changes. The > non concurrent test had already fixed the suspect string, but the > concurrent test did not. By throwing away the code from Concurrent* and > making it extend the non-concurrent test, this bug is fixed. > > The test has also been tuned to do fewer operations and take less time. > > > Diffs > ----- > > > gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java > 0c32d1fee204544cae490da9c048713c65fe6d29 > > gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentSerialGatewaySenderOperationsDUnitTest.java > b709334f7272cf50498e4d4ce910434691652343 > > gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/serial/SerialGatewaySenderOperationsDUnitTest.java > d30289b7ed2130b25be6b865f3516b466e28a820 > > Diff: https://reviews.apache.org/r/42885/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >