> On Jan. 28, 2016, 1:46 a.m., xiaojian zhou wrote: > > gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java, > > line 981 > > <https://reviews.apache.org/r/42889/diff/1/?file=1224475#file1224475line981> > > > > I have been thinking of make this method more generic to be shared by > > all the WAN test cases and AEQ test cases. > > > > Others look good.
This bit of code was repeated in 12 tests in this file and probably a bunch of times in other files too. I'll move it up to WANTestBase. - Barry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42889/#review116686 ----------------------------------------------------------- On Jan. 28, 2016, 1:37 a.m., Barry Oglesby wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42889/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 1:37 a.m.) > > > Review request for geode, Dan Smith and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > GEODE-865: > ConcurrentParallelGatewaySenderOperation_2_DUnitTest.testParallelGatewaySenders_SingleNode_UserPR_localDestroy_RecreateRegion > > - add lambda support (mostly but not completely done) > - refactored similar behavior out into local methods > > > Diffs > ----- > > > gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/WANTestBase.java > 230c8d8ce6f903cf5e4b9c8bf42b87ca04271647 > > gemfire-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java > f770062e2a2fdb8c9d35cd2d4f76ac96fa56ac37 > > Diff: https://reviews.apache.org/r/42889/diff/ > > > Testing > ------- > > > Thanks, > > Barry Oglesby > >
