----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42884/#review116976 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java <https://reviews.apache.org/r/42884/#comment178048> I think it would be better to keep this method. It makes the code in the two callers simpler and we don't need to worry about enabling/disabling the RefCountTracker around the releaseAddress call that is not off-heap. You are correct that their is no need to do this; but their is also no harm. - Darrel Schneider On Jan. 28, 2016, 11:55 p.m., Sai Boorlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42884/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2016, 11:55 p.m.) > > > Review request for geode, Darrel Schneider and Swapnil Bawaskar. > > > Repository: geode > > > Description > ------- > > Added unit tests to cover OffHeapRegionEntryHelper. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/DataAsAddress.java > dff1d8f196eb37a9613b3fdb9781bbeb2bc78846 > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelper.java > 1731b01a0a86c17824627123153c9c009dc22ed1 > > gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/OffHeapRegionEntryHelperJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42884/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Sai Boorlagadda > >
