----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43162/#review117718 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java (line 1165) <https://reviews.apache.org/r/43162/#comment178994> Seems like we can create new method from run {} method. Something like that public void run() { doFinalCheckNew(initiator, cv, mbr, reason); } Then we can this new method with bool(removal), as you are doing. And then let this do finalcheck. - Hitesh Khamesra On Feb. 3, 2016, 11:21 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43162/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2016, 11:21 p.m.) > > > Review request for geode and Hitesh Khamesra. > > > Repository: geode > > > Description > ------- > > Somehow we missed modifying checkIfAvailable to use the "final" check method > after Jianxia implemented the tcp/ip checks. This modifies checkIfAvailable > to do so. > > Since doFinalCheck uses a thread pool I modified the SuspectRequest to hold > the results of the check so that they are accessible from the > checkIfAvailable method. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > 172926bf47a9f6633297cdffc5135782f48e16b5 > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/messages/SuspectRequest.java > 5c26fa82b9fa97b55ac9c2c74811eb82aa67dcaf > > gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/PartitionedRegion.java > 09e945b846806a3deab9fa0357a3cb31aa1f7073 > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java > 70285c7a0e5f6700c723eb17fb8d68077d68e730 > > Diff: https://reviews.apache.org/r/43162/diff/ > > > Testing > ------- > > > Thanks, > > Bruce Schuchardt > >
