> On Feb. 8, 2016, 10:01 p.m., Dan Smith wrote: > > I don't think adding the jar to all projects is the correct way to fix > > this. We really shouldn't have *anything* that we're adding to the > > classpath of all projects unless it's really needed in all projects.
When I execute "./gradlew javadoc" with the changeset in the diff, it fixes the following javadoc warnings. Without the diff in place, these warnings are generated by the build: :pivotalgf-assembly:docsC:\dev\gemfire_CLEAN\open\gemfire-core\src\main\java\com\gemstone\gemfire\cache\FailedSynchronizationException.java:33: warning - Tag @see: reference not found: javax.transaction.UserTransaction#setRollbackOnly C:\dev\gemfire_CLEAN\open\gemfire-core\src\main\java\com\gemstone\gemfire\cache\FailedSynchronizationException.java:33: warning - Tag @see: reference not found: javax.transaction.Transaction#registerSynchronization C:\dev\gemfire_CLEAN\open\gemfire-core\src\main\java\com\gemstone\gemfire\cache\FailedSynchronizationException.java:33: warning - Tag @see: reference not found: javax.transaction.Status C:\dev\gemfire_CLEAN\open\gemfire-core\src\main\java\com\gemstone\gemfire\cache\SynchronizationCommitConflictException.java:27: warning - Tag @see: reference not found: javax.transaction.UserTransaction#commit - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43338/#review118302 ----------------------------------------------------------- On Feb. 8, 2016, 9:46 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43338/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 9:46 p.m.) > > > Review request for geode and Dan Smith. > > > Bugs: GEODE-945 > https://issues.apache.org/jira/browse/GEODE-945 > > > Repository: geode > > > Description > ------- > > Add compile dependency for javax.transaction:javax.transaction-api:1.2 to > satisfy javadoc references to types in javax.transaction package. > > > Diffs > ----- > > gradle/java.gradle 015da2f > > Diff: https://reviews.apache.org/r/43338/diff/ > > > Testing > ------- > > > Thanks, > > Kirk Lund > >
