----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43728/ -----------------------------------------------------------
Review request for geode, Hitesh Khamesra, Jianxia Chen, and Udo Kohlmeyer. Repository: geode Description ------- This fixes the NPE and adds a unit test for it. I also did some cleanup of Message, removing unused methods and old commented out code and changing the earlyAck byte to be "flags" and not allow external manipulation of the byte's bits. Diffs ----- gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AbstractOp.java 0ae0437aeccdeac50ea2fbffeb858a208303ecd3 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AddPDXEnumOp.java b88948df7232406927efc790ae2b8128a55e0291 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AddPDXTypeOp.java 92dd246c94e421691987e925c99d595c849add47 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/AuthenticateUserOp.java b0f0cec9abd365c72f7161ba7af674b0dda92873 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/CloseConnectionOp.java 943f0a3695d4ac54fb1a1fa8304471f408d69504 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/CommitOp.java e04a46674eb90a23c819923bdbeb78b054543397 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetClientPRMetaDataOp.java f88d1e9d483b742e98e5f27fd80a6305aced3126 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetClientPartitionAttributesOp.java 004872c4315adbf475ad5a5bf48f5e1eff601804 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetEventValueOp.java 7dfe9af0b18a4322c33d7d8417168d67d546a247 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetFunctionAttributeOp.java 9e63fba27e8a0959c23f1eac4b885edf7f8d1500 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetPDXEnumByIdOp.java d3e9efb8c676da2d8a73a118ef6a6410e7f489a8 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetPDXEnumsOp.java 0cb5d33971156c5b1405672c73a6b349f4e7178c gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetPDXIdForEnumOp.java 81a2b1bec7dbfd3dd778da19e8bc2f53ee694987 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetPDXIdForTypeOp.java d771cb61b2215bef5e25b4bb30b087f07a6fc038 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetPDXTypeByIdOp.java e0b2810a2e1bfff9fbe48c49ed4878c78f4c5085 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/GetPDXTypesOp.java 299019297fe9fb9e134de21eef34ff6aef7ddd64 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/MakePrimaryOp.java 59b99f08686c66b0e9354abd4143f48d83d082ec gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PingOp.java e0bc81bc5b69e8a048d838874d22b2ac2ca6e712 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/PrimaryAckOp.java 0b65c564f5372f0070a891973b10f1b7157c0d3c gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ProxyCacheCloseOp.java 53b8fa9e91543000355b853acabe93799cce7fbb gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/ReadyForEventsOp.java a003538bf0d347bee843696f50e50e1a86adc3fa gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/RegisterDataSerializersOp.java b2b975f2a30a7f2e5266d63eff1f51f23b7ec976 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/RegisterInstantiatorsOp.java 93d3756a8cf010e707d1250ad0bb90447f97f157 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/RollbackOp.java 2793f321e865833e1fbd9b0c5f64a1363a4be74e gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/SizeOp.java 6d6908350c5db773aa1480a2ca27a7c90bd3c652 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/TXFailoverOp.java 1fecc7d6369d62d80cbef2b3864e2372d11d8713 gemfire-core/src/main/java/com/gemstone/gemfire/cache/client/internal/TXSynchronizationOp.java 48d66f2f2dc692be5b041b6f88979f12df4e9a3c gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java f4216ac8acef7b53f1cbdd83ef58049b14f95521 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/BaseCommand.java 52ea6f55b55a656bdb02fb192c6d49ca309e07f8 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Message.java f6866bf58bf6a30b2b35a4d80d94339b204148e3 gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/Part.java 5418c6877c52f1962c71f32002c1cc466662af3b gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/MessageJUnitTest.java PRE-CREATION gemfire-wan/src/main/java/com/gemstone/gemfire/cache/client/internal/GatewaySenderBatchOp.java 2eb0896bb19ec29498f8c6bccdde1c47c30bd423 Diff: https://reviews.apache.org/r/43728/diff/ Testing ------- Thanks, Bruce Schuchardt
