> On Feb. 17, 2016, 1:24 a.m., anilkumar gingade wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/PrimaryKeyIndexCreationHelper.java, > > line 80 > > <https://reviews.apache.org/r/43624/diff/1/?file=1252218#file1252218line80> > > > > How did this use to work for non-pk indexes??? > > Jason Huynh wrote: > There was a fix a few years ago before Geode that addressed this issue > for other types of indexes (in FunctionalIndexCreationHelper).
Thanks Jason... - anilkumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43624/#review119397 ----------------------------------------------------------- On Feb. 17, 2016, 12:15 a.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43624/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2016, 12:15 a.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, and Dan Smith. > > > Repository: geode > > > Description > ------- > > Iterator naming is set at the bucket index level, however lookups are done on > the PartitionIndex level. So when a lookup occurs, it will not find the > correct mapping to index iterator name. This leads to no matching indexes > when expecting a primary key index lookup. > The fix is to populate a shared map at the PartitionIndex level for all > bucket indexes and do the look up at the PartitionIndex level. > > There was also a side bug where the isPopulate flag is not being set for > PrimaryKey indexes. > > Clean up of IndexUseTest. The actual test additions are testPKIndexUseWithPR > and testPKIndexUseWithReplicate. > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/IndexManager.java > 3784327 > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/query/internal/index/PrimaryKeyIndexCreationHelper.java > b43f491 > > gemfire-core/src/test/java/com/gemstone/gemfire/cache/query/internal/index/IndexUseJUnitTest.java > c3223d8 > > Diff: https://reviews.apache.org/r/43624/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
