----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43788/#review119990 -----------------------------------------------------------
gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java (line 452) <https://reviews.apache.org/r/43788/#comment181350> Better add a {} for this if statement gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java (line 488) <https://reviews.apache.org/r/43788/#comment181351> Better add a {} for this if statement gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java (line 682) <https://reviews.apache.org/r/43788/#comment181355> return super.doTCPCheckMember(suspectMember, port)? - Jianxia Chen On Feb. 19, 2016, 10:47 p.m., Hitesh Khamesra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43788/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2016, 10:47 p.m.) > > > Review request for geode, Bruce Schuchardt, Jianxia Chen, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > While doing tcp check, now we do request heartbeat from unresponsive member. > This is udp call and we don't wait for response. It is processed by another > thread. Current thread continue with tcp check and if it fails, then it look > for heartbeat. > > Added unit test > > > Diffs > ----- > > > gemfire-core/src/main/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitor.java > beb781d > > gemfire-core/src/test/java/com/gemstone/gemfire/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java > 9562e41 > > Diff: https://reviews.apache.org/r/43788/diff/ > > > Testing > ------- > > testing > > > Thanks, > > Hitesh Khamesra > >
