----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44035/#review120748 -----------------------------------------------------------
I seem to recall something about checking for Tokens, too. Am I making that up or is it not a concern anymore? - Bruce Schuchardt On Feb. 25, 2016, 7:32 p.m., Jianxia Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44035/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2016, 7:32 p.m.) > > > Review request for geode, Bruce Schuchardt, Darrel Schneider, Hitesh > Khamesra, and Udo Kohlmeyer. > > > Repository: geode > > > Description > ------- > > Avoid calling PutAllOperationContext.UpdateOnlyMap.exportValue when the map > entry is ExportableEntry. Because calling exportValue will result in > unnecessary deserialization in this case. For this case, > LocalRegion.verifyPutAllMap only need check whether the key or value is null. > No deserialization is required for PutAll map verification. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/cache/operations/PutAllOperationContext.java > b05216b > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/LocalRegion.java > b6d8c49 > > Diff: https://reviews.apache.org/r/44035/diff/ > > > Testing > ------- > > > Thanks, > > Jianxia Chen > >
