It looks like there is a way to create a Web project in Eclipse and a
plugin for Gradle to create them but I don't know enough about either to
work on it.
I've created a JIRA ticket to track the issue and reverted my changes to
AgentUtil.
All of the tests have been modified in setUp to fail quickly if they
can't find the WAR file.
Le 2/25/2016 3:20 PM, Dan Smith a écrit :
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44020/
On February 25th, 2016, 7:21 p.m. UTC, *Dan Smith* wrote:
geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java
<https://reviews.apache.org/r/44020/diff/1/?file=1271099#file1271099line57>
(Diff revision 1)
public class AgentUtil {
57
// initial checks for unit-test locations
It looks like you're setting things up so that running a test
in eclipse will find a war file built by the command line
build? I think that's going to be confusing. People will
modify the code in eclipse and expect the modifications to
have an effect when the run the test.
On February 25th, 2016, 9:42 p.m. UTC, *Bruce Schuchardt* wrote:
I don't see another way to allow the tests to run in Eclipse.
They deploy the WAR into a web server. Do you think I should
just disable the ability to run them in Eclipse? That'll make
it harder for the people developing new tests for REST.
Hmm. It's too bad we can't just test this stuff with the eclipse
generated files. I guess it's better to at least be able to write the
test in eclipse. Maybe we should have a convention of putting anything
that relies on command line generated artifacts in a special place or
some other way of making it clear that they are testing the command
line build.
- Dan
On February 25th, 2016, 9:41 p.m. UTC, Bruce Schuchardt wrote:
Review request for geode, Anthony Baker and Dan Smith.
By Bruce Schuchardt.
/Updated Feb. 25, 2016, 9:41 p.m./
*Repository: * geode
Description
A number of unit tests were still sitting in the work queue to be
moved to open-source including all of the REST API tests. This change
set shows the build changes and AgentUtil changes needed to accomodate
the new tests but does not show the new tests. The tests are being
added to the geode-web-api project, and all of the support classes in
geode-core's com.gemstone.gemfire.rest.internal.web.controllers
package are being moved to that project.
Testing
The new tests pass when run from gradle or eclipse
Diffs
*
geode-core/src/main/java/com/gemstone/gemfire/management/internal/AgentUtil.java
(0310658d2182f90bc8e2041cd0f6b0f0b53c6568)
* geode-web-api/build.gradle (51848c2b750373cfcc1c5ba9f0b24417ac38745d)
* gradle/dependency-versions.properties
(611ee7a413d70d9c72b5ca0a5384b4dee7c26c60)
View Diff <https://reviews.apache.org/r/44020/diff/>
