----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44193/#review121510 -----------------------------------------------------------
Ship it! Seems like a good incremental improvement! - Dan Smith On March 1, 2016, 12:48 a.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44193/ > ----------------------------------------------------------- > > (Updated March 1, 2016, 12:48 a.m.) > > > Review request for geode, Anthony Baker, anilkumar gingade, Barry Oglesby, > Dan Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Moved some of the dependencies from the common java.gradle to the sub > projects that actually used these dependencies. > Modified some of the scopes for the dependencies > > I made a mistake and accidently checked in the actual fix for GEODE-562 in an > unrelated test fix commit a while back, so that is why you won't actually see > the gradle/dependency-version.properties change here. I'll be sure to update > the ticket with the actual commit that it snuck into. > > There are quite a few dependencies that are used in a class or two that > possibly can either be moved/removed or modified but those should probably > specified directly and be seperate taskes in themselves. > > > Diffs > ----- > > extensions/geode-modules/build.gradle f96fde6 > geode-core/build.gradle 1aa07ee > geode-pulse/build.gradle 0cd1ef4 > geode-rebalancer/build.gradle 9efdff2 > gradle/java.gradle 06fb766 > > Diff: https://reviews.apache.org/r/44193/diff/ > > > Testing > ------- > > running precheckin > > suggestions for any tests that should be run? > > > Thanks, > > Jason Huynh > >
