-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44242/#review121865
-----------------------------------------------------------




geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherWithSpringJUnitTest.java
 (line 41)
<https://reviews.apache.org/r/44242/#comment183713>

    Can this test still be kept around, but perhaps moved to geode-assembly? 
Especially if we're shipping with SDG we should test that this works.
    
    Until https://jira.spring.io/browse/SGF-476 is done, the test can just be 
`@Ignore`d.


- Jens Deppe


On March 2, 2016, 10:09 p.m., Dan Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44242/
> -----------------------------------------------------------
> 
> (Updated March 2, 2016, 10:09 p.m.)
> 
> 
> Review request for geode, Jason Huynh, Jens Deppe, and John Blum.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Removing the direct use of Spring Data Gemfire from within the geode
> code. Replacing it with a SPI that allows the user to override the
> behavior of ServerLauncher.start with their own implementation that
> creates a cache.
> 
> Spring Data Gemfire can provide an implementation that bootstraps the
> cache using spring, if spring-xml-location is specified.
> 
> Users should implement ServerLauncherCacheProvider. The cache will be
> created by the first provider that returns a non null cache. If no
> providers create a cache, the cache will be created by the
> ServerLauncher itself.
> 
> It would be nice to move the spring-xml-location parameter itself into
> the interface, but this is hard to do because gfsh determines the
> parameters to start-server by looking at the arguments in the command
> class. So I left spring-xml-location alone.
> 
> Removing the spring data jar from the compile time dependencies. I've
> moved it to the geode-assembly project, so it is still shipped for the
> moment.
> 
> 
> Diffs
> -----
> 
>   geode-assembly/build.gradle 5930f13c5307e0cd70396b019263176a377d415a 
>   geode-core/build.gradle 041dc07c860c008f117d37969ee688375c2a348d 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncher.java 
> c991cc147d975a9bfd44d0c3720f80bc3e35f7ab 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/ServerLauncherCacheProvider.java
>  PRE-CREATION 
>   
> geode-core/src/main/java/com/gemstone/gemfire/distributed/internal/DefaultServerLauncherCacheProvider.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/LauncherTestSuite.java
>  73a23374b82f998780ae8c757d869446dcfaca71 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/MockServerLauncherCacheProvider.java
>  PRE-CREATION 
>   
> geode-core/src/test/java/com/gemstone/gemfire/distributed/ServerLauncherWithSpringJUnitTest.java
>  bf82af8268f0b35c6ed15b26783ef37c9c329c10 
>   
> geode-core/src/test/resources/META-INF/services/com.gemstone.gemfire.distributed.ServerLauncherCacheProvider
>  PRE-CREATION 
>   geode-core/src/test/resources/spring/spring-gemfire-context.xml 
> a728493be7ee2a960dc3c9e5e8c449686d6b09cd 
>   gradle/rat.gradle abda0345d89635a41feed4dd4d68d7cb5e1d6d93 
> 
> Diff: https://reviews.apache.org/r/44242/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Smith
> 
>

Reply via email to