> On March 15, 2016, 9:37 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/xmlcache/CacheServerCreation.java, > > line 55 > > <https://reviews.apache.org/r/44858/diff/1/?file=1299935#file1299935line55> > > > > Isn't this changing the default CacheServer port from 40404 to zero > > when creating the cache from XML? That doesn't seem like something we want > > to do. > > Bruce Schuchardt wrote: > Can you just change the test itself to set the port to zero?
Yes. Please see the updated diff. My concern is that there might be other tests which have could also possibly have "Address already in use" error. - Jianxia ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44858/#review123753 ----------------------------------------------------------- On March 15, 2016, 10:18 p.m., Jianxia Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44858/ > ----------------------------------------------------------- > > (Updated March 15, 2016, 10:18 p.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo > Kohlmeyer. > > > Repository: geode > > > Description > ------- > > In order to avoid an already used port, use tcp port 0, so that the test will > be automatically assigned an available port. > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/cache30/CacheXml80DUnitTest.java > 98134ce > > Diff: https://reviews.apache.org/r/44858/diff/ > > > Testing > ------- > > precheckin > > > Thanks, > > Jianxia Chen > >
