GitHub user nabarunnag opened a pull request:
https://github.com/apache/incubator-geode/pull/116
GEODE-247: Fix in executeQuery function to use the bucket parameter
GEODE-247: Fix in executeQuery function to use the bucket parameter and
added tests cases for it.
* modification of the function executeQuery to use the parameter bucket
rather than ignoring it.
* added integration test QueryWithBucketParameterIntegrationTest which
tests variations in the bucket parameter.
* code improvements done as per the review comments in github pull request
* placed MyValue, createAndPopulateSet and populateRegion into a separate
file TestData.java as being reused by two test cases to avoid redundant code
* modified BugJUnitTest to import the TestData package and replaced for
loops with IntStreams and lambda functions.
NOTE: This is an internal API which needs to be deprecated and replaced
with an API without the bucket parameter.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nabarunnag/incubator-geode feature/GEODE-247
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-geode/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit ffdc3064d3a64cd0f92fced983bcbaa0cffc2f47
Author: nabarun <[email protected]>
Date: 2016-03-17T22:11:41Z
GEODE-247: Fix in executeQuery function to use the bucket parameter and
added tests cases for it.
* modification of the function executeQuery to use the parameter bucket
rather than ignoring it.
* added integration test QueryWithBucketParameterIntegrationTest which
tests variations in the bucket parameter.
* code improvements done as per the review comments in github pull request
* placed MyValue, createAndPopulateSet and populateRegion into a separate
file TestData.java as being reused by two test cases to avoid redundant code
* modified BugJUnitTest to import the TestData package and replaced for
loops with IntStreams and lambda functions.
NOTE: This is an internal API which needs to be deprecated and replaced
with an API without the bucket parameter.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
