----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44961/#review124101 -----------------------------------------------------------
Ship it! Ship It! - Kirk Lund On March 17, 2016, 3:44 p.m., Jens Deppe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44961/ > ----------------------------------------------------------- > > (Updated March 17, 2016, 3:44 p.m.) > > > Review request for geode, Bruce Schuchardt, Jinmei Liao, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > GEODE-980: Convert all SerializableCallables to lambda expressions > > - This is only for CreateAlterDestroyRegionCommandsDUnitTest > > GEODE-980: Refactor destroyRegion command > > - Remove a bunch of logic separating local regions vs. other types. For > distributed regions we just need to find one member ('cos the destroy > region call gets distributed) and for local regions we choose each > member hosting the named region Then do a function call against all > these members. > > GEODE-980: The member's local hostname is just an IP address > > - Trouble on Mac OS is that the hostname is not tied to a particular > address like other *nix systems. A typical *nix system might have the > hostname defined in /etc/hosts or resolvable via DNS. The hostname/IP > mapping remains fixed and consistent. Under Mac OS (and at least under > Java) the InetAddress.getLocalHost call is not deterministic and may > associate the local hostname with any of the hosts' currently assigned > IP addresses. There is no mapping done through /etc/hosts. This also > means that given a localhost InetAddress, a reverse DNS lookup of the > address will fail. > - By using only the IP address for the local hostname, the member ID > remains consistent. > > > Diffs > ----- > > geode-core/src/main/java/com/gemstone/gemfire/internal/SocketCreator.java > 5bfa7bd3badb565db96dd504338e6f3955ecb1b7 > > geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java > bf1fdf0f60d2c8f357d54ff7ca9c39561568c6a0 > > geode-core/src/test/java/com/gemstone/gemfire/management/internal/cli/commands/CreateAlterDestroyRegionCommandsDUnitTest.java > 9f6b14119b5b78977dd901dc5ba49aef322470e2 > > Diff: https://reviews.apache.org/r/44961/diff/ > > > Testing > ------- > > Ran precheckin > > > Thanks, > > Jens Deppe > >
