----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45776/#review127606 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizer.java (line 55) <https://reviews.apache.org/r/45776/#comment190998> Do you want to update this comment? geode-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizer.java (line 59) <https://reviews.apache.org/r/45776/#comment190999> Is a more complete solution possible instead of a list of special cases? - Darrel Schneider On April 6, 2016, 6:14 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45776/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 6:14 p.m.) > > > Review request for geode, Darrel Schneider and Sai Boorlagadda. > > > Repository: geode > > > Description > ------- > > This is not a complete fix for the http session management problem, but > this is a safety catch we should probably have in the product to avoid > following references into InternalDistributedSystem when computing the > size of a users object. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizer.java > d94487cbe39200ad937ffe7adc2d3b9e0ee6e81a > > geode-core/src/test/java/com/gemstone/gemfire/internal/size/ReflectionObjectSizerJUnitTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45776/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
