----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46065/#review128448 -----------------------------------------------------------
geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java (line 220) <https://reviews.apache.org/r/46065/#comment191870> Instead of a try-catch block, unless we are checking the message, we can instead use a @Test (expected=UnsupportedOperationException.class) as the tag instead. - Jason Huynh On April 12, 2016, 6:30 a.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46065/ > ----------------------------------------------------------- > > (Updated April 12, 2016, 6:30 a.m.) > > > Review request for geode and Dan Smith. > > > Bugs: geode-1212 > https://issues.apache.org/jira/browse/geode-1212 > > > Repository: geode > > > Description > ------- > > The objective is: > 1) If tried to create LuceneIndex on a replicated region, should throw > UnsupportedOperationException > 2) No API to mislead user to create index on replicated region > 3) add test case to verify > > I did not remove the class LuceneIndexForReplicatedRegion, since it has > implemented to throw UnsupportedOperationException for all its methods. This > is also an option. > > > Diffs > ----- > > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java > 7002567 > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImpl.java > 1a5dd1a > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneQueryImplJUnitTest.java > 3975ac3 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java > 159fd46 > > Diff: https://reviews.apache.org/r/46065/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
