----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46123/ -----------------------------------------------------------
Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Udo Kohlmeyer. Repository: geode Description ------- The test is using a very small port range (only 3 available ports), in order to produce expected GemFireConfigException. See the following code: config.setProperty(DistributionConfig.MEMBERSHIP_PORT_RANGE_NAME, ""unicastPort"-"+(unicastPort+2)); If the port range is changed in the above line, either adding a port or removing a port, it will result in test failure. However, the failure won't be the one reported by the ticket. With such a small port range, if one of the ports is being used by others, it will get SystemConnectException(RMIException) before the expected GemFireConfigException is thrown. One option is to ignore the RMIException, since adding a port will also fail the test. Diffs ----- geode-core/src/test/java/com/gemstone/gemfire/distributed/DistributedSystemDUnitTest.java 0109845 Diff: https://reviews.apache.org/r/46123/diff/ Testing ------- Thanks, Jianxia Chen
