----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46216/#review128943 -----------------------------------------------------------
Ship it! Just curious: what happens if someone enters wrong passwords? May want to add logic to abort after a set number of retries. - Nitin Lamba On April 14, 2016, 5:54 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46216/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 5:54 p.m.) > > > Review request for geode, Anthony Baker, Mark Bretl, and Nitin Lamba. > > > Repository: geode > > > Description > ------- > > The signArchives and uploadArchives tasks require a passwords to work. > Adding a flag to request a password prompt to fill in a password. > > ./gradlew uploadArchives -Paskpass > > This will pop up a swing dialog box asking for passwords to sign and > upload archives. > > This is not on by default because we don't want developers to have to > enter a password for every build. The build target depends on > signArchives but normally will skip it if the password property is not > set. > > > Diffs > ----- > > buildSrc/src/main/groovy/org/apache/geode/gradle/PasswordDialog.groovy > PRE-CREATION > gradle/publish.gradle 02b0e3c75b5f2bdb5b3260dba6cd17e3794847e0 > > Diff: https://reviews.apache.org/r/46216/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
