----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46239/#review129067 -----------------------------------------------------------
Ship it! Ship It! - xiaojian zhou On April 15, 2016, 12:16 a.m., Jason Huynh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46239/ > ----------------------------------------------------------- > > (Updated April 15, 2016, 12:16 a.m.) > > > Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan > Smith, and xiaojian zhou. > > > Repository: geode > > > Description > ------- > > Not sure if this is needed at this point, but with this new unit test it gets > slightly more coverage in a fraction of the time (takes 2 seconds on my > laptop for 18 tests) it takes to run LuceneServiceImplJUnitTest (9 seconds > for 5 tests). None of the cache calls are on a real cache so that gives some > speed savings, although as you can see, the difference is only in seconds at > this point. > > Allows ability to test that double initialize calls do not invoke multiple > file region creates (which may have been hard to test before or is this case > even possible?) > > refactored LuceneIndexForPartitionRegion so that a unit test for it could > test specific units, but also allowing tests for initialize() to be stubbed > out. > > > Diffs > ----- > > > geode-lucene/src/main/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegion.java > 25b63a4 > > geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexForPartitionedRegionTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46239/diff/ > > > Testing > ------- > > > Thanks, > > Jason Huynh > >
