> On April 20, 2016, 10:45 p.m., Bruce Schuchardt wrote: > > Looks okay but using keepers would be safer. When a locator starts, for > > instance, it consumes more than 1 tcp/ip port so it might use one of the > > others that you got from getRandomAvailableTcpPorts().
Using Keepers is a great idea. What would be required is an @After which will release all keepers. If one would do this is code we would have to have try-catch-finally. Where we release the keeper in the finally.. Otherwise the test won't clean up after itself - Udo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46457/#review129833 ----------------------------------------------------------- On April 21, 2016, 1:58 a.m., Udo Kohlmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46457/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 1:58 a.m.) > > > Review request for geode, Bruce Schuchardt, Hitesh Khamesra, and Jianxia Chen. > > > Repository: geode > > > Description > ------- > > GEODE-1268: Cleanup of multiple AvailablePort.getRandomAvailablePort > invocations with correct AvailablePortHelper invocation > > > Diffs > ----- > > > geode-core/src/test/java/com/gemstone/gemfire/distributed/LocatorDUnitTest.java > 3b5f23fcc3bcbf1f1d83c0d491636203e221cfc2 > > geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationDUnitTest.java > 961e8446628cd18bdbd847abf0b105cdfb020565 > > geode-core/src/test/java/com/gemstone/gemfire/security/ClientAuthorizationTestCase.java > 4cc8155328e40fb0ccba4d93ec6f9886436fe5ff > > geode-core/src/test/java/com/gemstone/gemfire/security/DeltaClientPostAuthorizationDUnitTest.java > 61ff55adbd8fb1f73ba77eccb5d72641df88c867 > > geode-core/src/test/java/com/gemstone/gemfire/security/P2PAuthenticationDUnitTest.java > 56f5186685e60ff8f0827f9b26332c59f65d89cd > > geode-cq/src/test/java/com/gemstone/gemfire/security/ClientAuthzObjectModDUnitTest.java > 012ac332c181454ff68a5d1b60df773402cce756 > > geode-cq/src/test/java/com/gemstone/gemfire/security/ClientCQPostAuthorizationDUnitTest.java > e3e788688919d19615dfdfc9a528772810816e2b > > geode-cq/src/test/java/com/gemstone/gemfire/security/ClientPostAuthorizationDUnitTest.java > 963d2f02d061b6529e35aef14024e684007f4926 > > geode-cq/src/test/java/com/gemstone/gemfire/security/MultiUserDurableCQAuthzDUnitTest.java > 3a97b7c361c2082c44d76604460f630adaed12aa > > geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/misc/WANConfigurationJUnitTest.java > 84eb365ef3d698af6007757886edfa5cc5dabf2f > > Diff: https://reviews.apache.org/r/46457/diff/ > > > Testing > ------- > > precheckin running.... > > > Thanks, > > Udo Kohlmeyer > >
