----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46625/#review130480 -----------------------------------------------------------
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java (line 510) <https://reviews.apache.org/r/46625/#comment194214> Here, based on the stale-proxy we are trying to see whether to create new proxy or not... The isConnect() flag seems to be added for durable clients than non-durable... What if there is a stale proxy and its status is still connected? We also need to think about durable clients trying to connect to two servers in the same jvm (similar scenrio). The other solution could be: - While client is trying to make connection, if there is way to know the two servers are on the same jvm and ignore. OR If the endpoints are coming from locator, see locator can only return the server locations/connections that are not on the same jvm. - OR on the server side if the client is already connected with different port on this server (and there are multiple servers running on this JVM) - anilkumar gingade On April 25, 2016, 6:01 a.m., xiaojian zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46625/ > ----------------------------------------------------------- > > (Updated April 25, 2016, 6:01 a.m.) > > > Review request for geode and anilkumar gingade. > > > Bugs: GEODE-1183 > https://issues.apache.org/jira/browse/GEODE-1183 > > > Repository: geode > > > Description > ------- > > Current API allows us to create 2 cache servers on the same JVM, then the > client > will try to create 2 queues to that JVM, one secondary and one primary. > But the proxy is actually the same (since there's only one client), so the > CCN keeps destroying and recreating the proxy. > > To fix, we will keep the first proxy and reject the duplicate creating. > Then the secondary proxy will automatically become primary. > > > Diffs > ----- > > > geode-core/src/main/java/com/gemstone/gemfire/internal/cache/tier/sockets/CacheClientNotifier.java > 1ba2294 > > geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java > 8bf819c > > Diff: https://reviews.apache.org/r/46625/diff/ > > > Testing > ------- > > > Thanks, > > xiaojian zhou > >
